Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.12.0 release #153

Merged
merged 1 commit into from
Jul 13, 2023
Merged

0.12.0 release #153

merged 1 commit into from
Jul 13, 2023

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented May 31, 2023

No description provided.

@dralley dralley requested review from cmeister2 and drahnr May 31, 2023 18:38
@dralley dralley marked this pull request as draft June 2, 2023 14:40
@dralley dralley changed the title 0.11.1 release 0.12.0 release Jun 2, 2023
@newpavlov
Copy link
Contributor

The changes in my PRs are backwards compatible, so I think they can be released as v0.11.1.

@dralley
Copy link
Collaborator Author

dralley commented Jun 2, 2023

I'm going to get #146 merged and then do a release, I'd prefer not to do two of them if possible

@newpavlov
Copy link
Contributor

Then I think we should remove the build_time method as was suggested in the PR. Should I submit it?

@dralley
Copy link
Collaborator Author

dralley commented Jun 2, 2023

Let's have some discussion on #156

@dralley dralley force-pushed the master branch 3 times, most recently from 8f5f446 to 31723d6 Compare July 10, 2023 15:58
@dralley dralley marked this pull request as ready for review July 10, 2023 15:58
newpavlov
newpavlov reviewed Jul 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dralley
Copy link
Collaborator Author

dralley commented Jul 10, 2023 •
edited
Loading

@drahnr I take it that you don't have any objections to the prefix removal / type renaming changes from #159?

I merged those but I can wait for your opinion prior to the release if you wish.

drahnr
drahnr approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dralley dralley merged commit 500b9db into rpm-rs:master Jul 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov left review comments

@drahnr drahnr drahnr approved these changes

@cmeister2 cmeister2 Awaiting requested review from cmeister2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dralley @newpavlov @drahnr